Update UUID to take advantage of SE-0205 #19775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates UUID to use withUnsafePointer for lets
|
@benasher44 Welcome to the project, and thank you for contributing to Swift! I'm going to tag @moiseev for review here, but before then I'll kick off CI. @swift-ci please smoke test |
|
Thanks! |
|
@swift-ci please smoke test |
|
LGTM, and we probably want an equivalent patch in the Foundation repo. |
|
Agreed with @millenomi |
|
Published equivalent patch @ swiftlang/swift-corelibs-foundation#1728 :) |
|
@swift-ci please test and merge |
|
… I don't appear to have that magic power. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates UUID to use
withUnsafePointerforletsNow that SE-0205 has landed, we don't need to make local copies of the uuid byte tuples, in order to get pointers to them. We can use the new
withUnsafePointerthat works withlets.