Skip to content

[AST] Imported classes have no stored properties. #19789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

DougGregor
Copy link
Member

Avoid triggering the import of all of the members of an Objective-C
class to determine its stored properties, because we don't import
instance variables of Objective-C classes. rdar://problem/45060773

Avoid triggering the import of all of the members of an Objective-C
class to determine its stored properties, because we don't import
instance variables of Objective-C classes. rdar://problem/45060773
@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

@slavapestov
Copy link
Contributor

Can you write a counter-based test for this? See the existing tests in test/NameBinding like the one I recently added

@DougGregor
Copy link
Member Author

I'll try. Only the SIL optimizers seem to use getStoredProperties() in this way.

@swift-ci swift-ci merged commit 1dfb979 into swiftlang:master Oct 9, 2018
@DougGregor DougGregor deleted the no-storage-for-old-classes branch October 10, 2018 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants