Skip to content

[CodeCompletion] Handle TupleShuffleExpr in completion context analyzer #19792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Oct 9, 2018

(and TupleExpr at non-call argument position).
Now, unresolved member completion in array/dictionary literal should work.
For example:

enum SimpleEnum {
  case foo, bar, baz
}

let ary: [SimpleEnum] = [.foo, .<HERE>

let dict: [SimpleEnum: Any] = [
  .foo: 42,
  .bar: "other",
  .<HERE>: something
]

Also, Don't calculate convertibility to Any type. That would be a noise to type relation because anything is convertible to Any.

rdar://problem/43302814

(and TupleExpr at non-call argument position).
Now, unresolved member completion in array literal should work.

Also, Don't calculate convertibility to 'Any' type. That would be a
noise to type relation because anything is convertible to 'Any'.

rdar://problem/43302814
@rintaro
Copy link
Member Author

rintaro commented Oct 9, 2018

@swift-ci Please smoke test

@rintaro rintaro requested a review from benlangmuir October 9, 2018 11:56
Copy link
Contributor

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@benlangmuir benlangmuir merged commit 4bca887 into swiftlang:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants