SourceKit: the swift-lang requires the SDK Overlay #19798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @nkcsgexi |
|
@swift-ci please test |
|
Can we drop the Darwin dependency for SwiftLang so we don't need this change? I suspect SwiftLang still builds without the SDK overlay. |
|
Build failed |
|
@nkcsgexi - sure, I can loosen the dependency to just the standard library, pretty sure that works. |
The swift-lang swift module requires the standard library to be built and is part of the standard library component. Ensure that this is taken into consideration when we attempt to build it.
compnerd
force-pushed
the
source-kit-overlay
branch
from
6db52b8 to
db7b7a7
Compare
|
@swift-ci please test and merge |
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Oct 11, 2018
It looks like removing this dependency (swiftlang#19798) caused the linker error on https://ci.swift.org/view/Pull%20Request/job/swift-PR-osx-perf/
modelorganism
pushed a commit
to modelorganism/swift
that referenced
this pull request
Oct 12, 2018
It looks like removing this dependency (swiftlang#19798) caused the linker error on https://ci.swift.org/view/Pull%20Request/job/swift-PR-osx-perf/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swift-lang swift module requires the SDK overlay to be built (for the
dependency on Darwin). Ensure that this is taken into consideration when we
attempt to build it.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.