[let-properties-opt] Fix a correctness issue #1982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
swiftix
force-pushed
the
swift-2.2-branch
branch
from
a8ca13c to
9b3155e
Compare
|
@swift-ci Please test |
Re-factor and simplify the code. Improve correctness. The code is now simpler and handles more cases. More tests were added. The overall idea of this rewrite is that the pass basically tries to check if it can see all possible writes (i.e. initializations) into a given let property. Only if it can be proven that the pass sees all possible writes and all those initializations are producing the same constant, statically known value, the pass propagates this constant value into uses of a property. SR-1026 and rdar://25303106
swiftix
force-pushed
the
swift-2.2-branch
branch
from
9b3155e to
868e3cc
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Pull in a swift-2.2 fix for a correctness issue reported in rdar://25303106
Resolved bug number: (SR-1026)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.
Re-factor and simplify the code. Improve correctness.
The code is now simpler and handles more cases. More tests were added.
The overall idea of this rewrite is that the pass basically tries to check if it can
see all possible writes (i.e. initializations) into a given let property. Only if it can
be proven that the pass sees all possible writes and all those initializations are
producing the same constant, statically known value, the pass propagates
this constant value into uses of a property.
SR-1026 and rdar://25303106