Skip to content

Use target-swift-frontend #19889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

rposts
Copy link
Contributor

@rposts rposts commented Oct 15, 2018

test/IRGen/ELF-objc-sections.swift hard codes swift target to x86_64-unknown-linux-gnu. This results in failure of test case on s390x architecture.

This PR uses %target-swift-frontend to make it generic across Linux platforms.

@harlanhaskins
Copy link
Contributor

@swift-ci please test

@compnerd compnerd self-requested a review October 16, 2018 16:44
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppos that this is okay. We don't depend on anything specific to x86_64, it is more about the output format being ELF, which, AFAIK, is the case for *-linux-gnu targets.

@compnerd compnerd merged commit b259271 into swiftlang:master Oct 16, 2018
@rposts rposts deleted the swift4.2-s390x-ELFchange branch October 16, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants