[Exclusivity] Make the performance inliner aware of exclusivity checks #19894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eeckstein Can you please review? |
shajrawi
force-pushed
the
inline_exclusivity
branch
5 times, most recently
from
5ad7b32 to
a626f4a
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
eeckstein
reviewed
Oct 16, 2018
| @@ -407,6 +446,12 @@ bool SILPerformanceInliner::isProfitableToInline( | |||
| } | |||
| } | |||
|
|
|||
| Weight EntryW = SPA->getWeight(CalleeEntry, CallerWeight); | |||
There was a problem hiding this comment.
Why are you taking the weight of the entry block and not the weight of the block which contains the access(es)?
There was a problem hiding this comment.
When we visit the block that contains the accesses we might not have visited the entire function / further block might change our decision. by the time we traverse all blocks we 'lost' which block(s) contain accesses. but I agree this is less than ideal - will think about changing it
shajrawi
force-pushed
the
inline_exclusivity
branch
3 times, most recently
from
16ab56d to
1cdd6ba
Compare
|
@eeckstein I changed the benefit calculation per our off-line discussion |
shajrawi
force-pushed
the
inline_exclusivity
branch
from
1cdd6ba to
9280b85
Compare
shajrawi
force-pushed
the
inline_exclusivity
branch
from
9280b85 to
2dc1015
Compare
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/45283321