[WIP] Use symbolic references more liberally. #19903
Conversation
lib/IRGen/IRGenMangler.cpp
Outdated
| if (auto ty = referent.dyn_cast<const NominalTypeDecl*>()) | ||
| appendContext(ty); | ||
| else if (auto proto = referent.dyn_cast<const ProtocolDecl*>()) | ||
| appendContext(proto); |
There was a problem hiding this comment.
Given that a ProtocolDecl is-a NominalTypeDecl, we have to be excessively careful with that referent type. Do we need the protocol vs. nominal type distinction here?
There was a problem hiding this comment.
Probably not. I started out giving type and protocols different symbolic reference discriminators, but that ended up being unnecessary.
| @@ -662,3 +662,247 @@ bool LinkEntity::isAvailableExternally(IRGenModule &IGM) const { | |||
| } | |||
| llvm_unreachable("bad link entity kind"); | |||
| } | |||
|
|
|||
| llvm::Type *LinkEntity::getDefaultDeclarationType(IRGenModule &IGM) const { | |||
There was a problem hiding this comment.
This is a very nice and mostly unrelated cleanup ;)
lib/IRGen/MetadataRequest.cpp
Outdated
| LinkEntity::forProtocolConformanceDescriptor(conf->getRootNormalConformance())); | ||
|
|
||
| // \3 - direct reference, \4 - indirect reference | ||
| baseKind = 5; |
There was a problem hiding this comment.
Shouldn't this be 3 instead of 5?
| if (auto retroContext = conformance->getRetroactiveContext()) { | ||
| module = retroContext->getModuleContext(); | ||
| } else { | ||
| // FIXME: Assume the protocol's module for a non-retroactive conformance |
There was a problem hiding this comment.
Non-retroactive conformances could be either in the protocol's module or the conforming type's module. If we need it, we could add a bit to the conformance descriptor to say which one it is...
| (const ContextDescriptor *) context, | ||
| {}, Dem); | ||
| }); | ||
| Demangle::mangleNode(node, ExpandResolvedSymbolicReferences(Dem)); |
There was a problem hiding this comment.
Thanks for cleaning up the DRY violations here
docs/ABI/Mangling.rst
Outdated
| ~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The Swift compiler emits mangled names into binary images to encode | ||
| references to types for runtime instantiation and reflection.Within an |
There was a problem hiding this comment.
Missing space after "reflection."
|
Indirect symbolic references will let us re-land #19848 |
jckarter
force-pushed
the
more-symbolic-references
branch
2 times, most recently
from
1cb1873 to
388ddfe
Compare
jckarter
force-pushed
the
more-symbolic-references
branch
from
388ddfe to
6479f7c
Compare
|
Note that this is obsoleted by #20005, so I'm going to go ahead and close it. |
Introduce symbolic references for indirect references to type context descriptors in other object files, and a new kind for references to protocol conformance descriptors (which will be used to mangle general generic arguments for key paths)
TODO:
test/Reflectiontests)Deferred:
ObjectMemoryReaders need to learn to resolve relocations among multiple disk files, alas. For now, I've kept symbolic references across files disabled.