Fix typo correction crash #19905
Merged
Fix typo correction crash #19905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes <rdar://problem/45242943> / <https://bugs.swift.org/browse/SR-8984>.
…e possible The former appears in the code base a lot more frequently than the latter, which returns a GenericTypeParamType *. Use it only in places where the more specific type is intended.
The lazy creation of the generic parameter list is not necessary.
We actually want to not use types at all here and instead refactor this code to use the various decl-level requests instead... but for now lets be consistent between typo corrections inside function and type context.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a couple of related cleanups.
Fixes rdar://problem/45242943 / https://bugs.swift.org/browse/SR-8984.