[ConstraintSystem] Extend solver support for designated types for ope… #19909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rators. Have the constraint solver consider multiple designated types for an operator. We currently consider the overloads from each in turn, stopping as soon as we have a solution. As a result, we can still end up with exponential type checking in some cases if an operator has more than a single designated type. This still allows us to reduce the base of that exponent, though, which makes it possible to increase the number of expressions we can type check successfully in practice.
|
@swift-ci Please smoke test |
xedin
approved these changes
Oct 16, 2018
| return true; | ||
| if (auto *extensionDecl = dyn_cast<ExtensionDecl>(parentDecl)) { | ||
| parentDecl = extensionDecl->getExtendedNominal(); | ||
| if (parentDecl == designatedNominal) { |
There was a problem hiding this comment.
You can use a extract resize + add into a separate function to deduplicate logic here for types and extensions
There was a problem hiding this comment.
Yes, I'll do that in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rators.
Have the constraint solver consider multiple designated types for an
operator. We currently consider the overloads from each in turn,
stopping as soon as we have a solution. As a result, we can still end
up with exponential type checking in some cases if an operator has
more than a single designated type. This still allows us to reduce the
base of that exponent, though, which makes it possible to increase the
number of expressions we can type check successfully in practice.