[RemoteMirrors] Fix the computation of the section start address in readMachOSections #19919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eadMachOSections. rdar://problem/45271231
|
@swift-ci please test |
dcci
reviewed
Oct 16, 2018
dcci
approved these changes
Oct 17, 2018
There was a problem hiding this comment.
I studied this change carefully and I think it's correct, but we really need to consider adding a testcase for it, otherwise it will bitrot. The original change which replaced the reader was supposedly NFC, which indicates we should increase coverage for this codepath.
|
I'm 800% agreed that it needs a test case. I'll see if I can figure one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/45271231