Skip to content

build: fix parameter name in cmake #19926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

compnerd
Copy link
Member

Fix the parameter name in _add_swift_library_single which would
previously not pass any value for the INSTALL_IN_COMPONENT due to a
missed alteration when the function was refactored. Spotted by
inspection.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Fix the parameter name in `_add_swift_library_single` which would
previously not pass any value for the `INSTALL_IN_COMPONENT` due to a
missed alteration when the function was refactored.  Spotted by
inspection.
@compnerd
Copy link
Member Author

CC: @gottesmm

@compnerd
Copy link
Member Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit 839e68f into swiftlang:master Oct 17, 2018
@compnerd compnerd deleted the refactoring-is-hard branch October 17, 2018 02:58
@gottesmm
Copy link
Contributor

Aich. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants