Skip to content

[CodeCompletion] Implement completion for 'get', 'set', 'willSet', 'didSet' #19950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2018
Merged

[CodeCompletion] Implement completion for 'get', 'set', 'willSet', 'didSet' #19950

merged 1 commit into from
Oct 19, 2018

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Oct 19, 2018

Implement 'get', 'set', 'willSet', 'didSet' completion at the beginning
of accessor position.

Support implicit getter.

  var value: Ty {
    <HERE> // 'get', 'set', 'willSet' and 'didSet' along with normal completion.
  }

  var value: Ty {
    get { return ... }
    <HERE> // 'get', 'set', 'willSet' and 'didSet' only.
  }

  var value: Ty {
    something()
    <HERE> // Normal completion without 'get', 'set', et al.
  }

rdar://problem/20957182

@rintaro
[CodeCompletion] Implement completion for 'get', 'set', 'willSet', 'd…
90fe0a7 
…idSet'

Implement 'get', 'set', 'willSet', 'didSet' completion at the beginning
of accessor position.

  var value: Ty {
    <HERE> // 'get', 'set', 'willSet' and 'didSet' along with normal
           // completion.
  }

  var value: Ty {
    get { return ... }
    <HERE> // 'get', 'set', 'willSet' and 'didSet' only.
  }

rdar://problem/20957182
@rintaro rintaro requested a review from benlangmuir October 19, 2018 05:32
@rintaro
Copy link
Member Author

rintaro commented Oct 19, 2018

@swift-ci Please smoke test

@benlangmuir benlangmuir merged commit 3af5bd1 into swiftlang:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @benlangmuir