[CodeCompletion] Polish unresolved member completion #19953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in unresolved member completion.
* Early exit for operators * Early exit for equal types
in unresolved member completion. e.g.
struct Node {
typealias Child = Node
init(children: [Child]) {}
}
let node: Node = .#^COMPLETE^#
This used to emit `.init(children:)` and `.Child(children:)`.
|
@swift-ci Please smoke test |
Using If we could lower the priority of these would that be sufficient? That would be fine with me since I can just type out "init" to filter to them anyway. |
|
I was a little unclear about this. I'm not removing beforeafterI'm only removing member type constructions, because they are basically dupes of |
I see. Could you clarify this in the PR description then? It says:
It sounds like this only applies to the second case. |
benlangmuir
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.init(children:)and.Child(children:). But emitting.Child(children:)is meaningless and may confuse users, especially if the type has many initializers.For example,
Stringhas several member types aliased toStringsuch asUnicodeScalarLiteralType,StringLiteralType. Emitting.StringLiteralType()along with.init()doesn't make sense.