Skip to content

Update tests to enable -solver-enable-operator-designated-types when … #19969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2018
Merged

Update tests to enable -solver-enable-operator-designated-types when … #19969

merged 2 commits into from
Oct 21, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Oct 21, 2018

…possible.

Add the following to all the expression type checker performance tests
that do not regress as a result:

  • -swift-version 5
  • -solver-disable-shrink
  • -disable-constraint-solver-performance-hacks
  • -solver-enable-operator-designated-types

…possible.

Add the following to all the expression type checker performance tests
that do not regress as a result:

- `-swift-version 5`
- `-solver-disable-shrink`
- `-disable-constraint-solver-performance-hacks`
- `-solver-enable-operator-designated-types`
@rudkx
Copy link
Contributor Author

rudkx commented Oct 21, 2018

@swift-ci Please smoke test

@rudkx rudkx requested a review from xedin October 21, 2018 17:52
…types when possible.

Add the following to all the expression type checker performance tests
that do not regress as a result:

- `-swift-version 5`
- `-solver-disable-shrink`
- `-disable-constraint-solver-performance-hacks`
- `-solver-enable-operator-designated-types`

This is a follow-up to 6de03f7, where
these should have been included.
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudkx
Copy link
Contributor Author

rudkx commented Oct 21, 2018

@swift-ci Please smoke test

@rudkx rudkx merged commit 23476e5 into swiftlang:master Oct 21, 2018
@rudkx rudkx deleted the test-updates branch October 21, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants