build: be more conservative when passing -target
#19973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the swift tools with gcc, we would fail as we would try to pass `-target` to gcc, which does not support this option. Invert the condition and only pass the argument when building with clang.
|
CC: @gottesmm |
|
@swift-ci please test and merge |
|
LGTM |
|
Question. I am not that familiar how gcc handles this without the -target option? |
|
Question. How does gcc handle this without the -triple option? I.e. can you give me the bigger picture here. |
|
@gottesmm - it can't, however, this is still "useful" for building just the tools. Unfortunately, I am now attempting to build with gcc 4.8, and that is not looking very good, I am finding there are constructs that we are using that gcc objects to and they are not easy to fix :/ I think that we really should setup a build bot to track the newer gcc builds if we want to keep the compiler itself fairly portable (which I think is a good thing to do). |
|
Question. How does gcc handle this without the -triple option? I.e. can you give me the bigger picture here.
… On Oct 21, 2018, at 3:33 PM, Saleem Abdulrasool ***@***.***> wrote:
@swift-ci please test and merge
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
devincoughlin
added a commit
that referenced
this pull request
Oct 30, 2018
In #19973 the logic that adds "-target" when building the C parts of the Standard Library and overlays was changed to use CMAKE_C_COMPILER_ID to only do so when the compiler ID is "Clang". However, on Apple toolchains the compiler ID is "AppleClang", so the target was no longer being explicitly set. Update the logic to relax the explicit check for "Clang" to also allow "AppleClang". rdar://problem/45579667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the swift tools with gcc, we would fail as we would try to
pass
-targetto gcc, which does not support this option. Invert thecondition and only pass the argument when building with clang.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.