[silgenpattern] Change catch emission to not be conditional on owners… #19986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
atrick
approved these changes
Oct 23, 2018
| // | ||
| // CHECK: [[SWITCH_MATCH_FAIL_BB]]([[SUBERROR:%.*]] : @owned $HomeworkError): | ||
| // CHECK: destroy_value [[SUBERROR]] | ||
| // CHECK: br [[RETHROW_BB:bb[0-9]+]]([[ERROR]] : $Error) |
There was a problem hiding this comment.
Does there need to be an end_borrow in SWITCH_MATCH_FAIL_BB1.
| // CHECK: br [[RETHROW_BB:bb[0-9]+]]([[ERROR]] : $Error) | ||
| // | ||
| // CHECK: [[CAST_NO_BB]]: | ||
| // CHECK: br [[RETHROW_BB]]([[ERROR]] : $Error) |
There was a problem hiding this comment.
Does there need to be an end_borrow in CAST_NO_BB.
| // CHECK: switch_enum [[SUBERROR]] : $HomeworkError, case #HomeworkError.TooHard!enumelt: {{bb[0-9]+}}, case #HomeworkError.TooMuch!enumelt: {{bb[0-9]+}}, default [[SWITCH_MATCH_FAIL_BB:bb[0-9]+]], | ||
| // | ||
| // CHECK: [[SWITCH_MATCH_FAIL_BB]]([[SUBERROR:%.*]] : @owned $HomeworkError): | ||
| // CHECK: destroy_value [[SUBERROR]] |
There was a problem hiding this comment.
Same question about the end_borrow here.
test/SILGen/errors.swift
Outdated
| @@ -176,6 +176,79 @@ func all_together_now(_ flag: Bool) -> Cat { | |||
| } | |||
| } | |||
|
|
|||
| // Make sure that if we catch an error in a throwing function we borrow the | |||
| // error and only consume the error by the rethrow block. | |||
There was a problem hiding this comment.
only consume the error in the rethrow block.
|
I'll fix the comment and add in the end_borrows (they are there I just didn't add the filecheck pattern). |
…hip verification being enabled. We were missing the code-coverage needed to show this so I added some examples to test/SILGen/errors.swift. rdar://29791263
gottesmm
force-pushed
the
pr-39aa50102d65c79c698d094c139faab143fa5bbe
branch
from
b34247a to
447a11a
Compare
|
@atrick made the changes. Merging! |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hip verification being enabled.
We were missing the code-coverage needed to show this so I added some examples
to test/SILGen/errors.swift.
rdar://29791263