[5.0][ConstraintSystem] Properly cache type for literal initialization coercions #19987
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcions Since original implicit coercion expression is preserved in AST it needs to have its simplified type cached in the constraint system in order for AST to get the correct type when solution is fully applied. Resolves: rdar://problem/45415874 (cherry picked from commit 4197cfd)
|
@swift-ci please test |
|
Build failed |
|
@shahmishal Do you know whats-up with these configuration errors? |
|
@swift-ci please clean test Linux platform |
|
Build failed |
|
Build failed |
|
Ok, looks like PR testing is completely broken for 5.0 branch :( |
|
@shahmishal Could you please force merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since original implicit coercion expression is preserved in AST
it needs to have its simplified type cached in the constraint
system in order for AST to get the correct type when solution
is fully applied.
Resolves: rdar://problem/45415874
(cherry picked from commit 4197cfd)