Skip to content

[CSDiagnostics] Fix requirement source lookup to support initializers #19990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

[CSDiagnostics] Fix requirement source lookup to support initializers #19990

merged 1 commit into from
Oct 23, 2018

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 22, 2018

Resolves: rdar://problem/45470505

@xedin xedin requested a review from nathawes October 22, 2018 23:42
@xedin
Copy link
Contributor Author

xedin commented Oct 22, 2018

@swift-ci please smoke test

nathawes
nathawes approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@xedin
Copy link
Contributor Author

xedin commented Oct 23, 2018

@swift-ci please smoke test

@xedin xedin merged commit 11d8e86 into swiftlang:master Oct 23, 2018
@xedin xedin mentioned this pull request Oct 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathawes nathawes nathawes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @nathawes