Foundation overlay needs to build with -swift-version 5 #19999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jrose-apple
reviewed
Oct 23, 2018
| @@ -664,6 +678,8 @@ internal final class _DataStorage { | |||
| _backing = .customMutableReference(data) | |||
| case .customMutableReference(let d): | |||
| d.replaceBytes(in: range, withBytes: replacementBytes, length: replacementLength) | |||
| @unknown default: | |||
| fatalError("Unknown Data backing type") | |||
There was a problem hiding this comment.
You're going to have to come back and do something about these. If Data really can grow new representations, you'll need to make sure they're handled even in inlined code. Sadly we already have a pattern for this: https://twitter.com/UINT_MIN/status/1020503397357760512
There was a problem hiding this comment.
Argh :( ok, I should talk to @phausler about this
There was a problem hiding this comment.
this code is going to have some changes coming in soon anyhow.
phausler
approved these changes
Oct 23, 2018
| @@ -664,6 +678,8 @@ internal final class _DataStorage { | |||
| _backing = .customMutableReference(data) | |||
| case .customMutableReference(let d): | |||
| d.replaceBytes(in: range, withBytes: replacementBytes, length: replacementLength) | |||
| @unknown default: | |||
| fatalError("Unknown Data backing type") | |||
There was a problem hiding this comment.
this code is going to have some changes coming in soon anyhow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Foundation overlay still builds in Swift 3 mode, which is going away. We should fix that!