Skip to content

[sema] Fix error message for enums with an invalid raw type #20002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2018
Merged

[sema] Fix error message for enums with an invalid raw type #20002

merged 2 commits into from
Oct 25, 2018

Conversation

adamshin
Copy link
Contributor

@adamshin
Copy link
Contributor Author

@swift-ci Please smoke test

@CodaFi
Copy link
Contributor

CodaFi commented Oct 24, 2018

Hi @adamshin, thanks for the patch.

You should run the tests and make sure to update them with respect to the changes you’ve made to the diagnostic text.

Also note that CI requires privileges for security purposes.

@adamshin
Copy link
Contributor Author

adamshin commented Oct 24, 2018 •
edited
Loading

Ah, thanks for the info. This is my first time contributing so I'm still learning the ropes. 🙂

@CodaFi
Copy link
Contributor

CodaFi commented Oct 24, 2018

No problem. I wrote a short explainer of some Swift-specific testing concepts that help here

A quick git grep reveals you should update the following files

test/Generics/inheritance.swift
test/IDE/print_ast_tc_decls_errors.swift
test/Parse/enum.swift
test/Sema/accessibility_private.swift
test/Sema/enum_raw_representable.swift

@beccadax
Copy link
Contributor

@swift-ci please smoke test

@CodaFi
Copy link
Contributor

CodaFi commented Oct 25, 2018

Weird

@swift-ci please smoke test macOS platform

@CodaFi
Copy link
Contributor

CodaFi commented Oct 25, 2018

⛵️

@CodaFi CodaFi merged commit 3082bbf into swiftlang:master Oct 25, 2018
@adamshin adamshin deleted the enum-raw-type-message branch October 25, 2018 20:29
@swift-ci swift-ci mentioned this pull request Oct 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamshin @CodaFi @beccadax