Skip to content

Fix SILCombiner::propagateConcreteTypeOfInitExistential. #20008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Fix SILCombiner::propagateConcreteTypeOfInitExistential. #20008

merged 1 commit into from
Oct 24, 2018

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Oct 24, 2018

A SIL argument index was being passed as an AST function type
parameter index. Don't do this.

I also cleaned up the peephole to avoid processing indirect results as
parameter indices, but that part is NFC.

Fixes rdar://45415719 Assertion failed: (Index < Length && "Invalid index!")

A SIL argument index was being passed as an AST function type
parameter index. Don't do this.

I also cleaned up the peephole to avoid processing indirect results as
parameter indices, but that part is NFC.

Fixes rdar://45415719 Assertion failed: (Index < Length && "Invalid index!")
@atrick atrick requested review from rajbarik and eeckstein October 24, 2018 01:48
@atrick
Copy link
Contributor Author

atrick commented Oct 24, 2018

@swift-ci test.

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atrick atrick merged commit 287e211 into swiftlang:master Oct 24, 2018
@atrick atrick deleted the silcombine-fix branch February 22, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants