Skip to content

[ConstraintSystem] Allow getPotentialBindings to find supertypes of o… #20017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2018
Merged

[ConstraintSystem] Allow getPotentialBindings to find supertypes of o… #20017

merged 1 commit into from
Oct 24, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Oct 24, 2018

…ptionals.

Improve enumerateDirectSupertypes so that for T? it will return U? if
U is a supertype of T. This is another form of direct supertype.

This is making up for a deficiency in the completeness of our Type
join implementation, which should be able to directly compute a join
of disparate types that share some common supertype, but sometimes
fails to in cases involving protocol compositions.

Fixes rdar://problem/45490737

(cherry picked from commit 85237aa)

…ptionals.

Improve enumerateDirectSupertypes so that for T? it will return U? if
U is a supertype of T. This is another form of direct supertype.

This is making up for a deficiency in the completeness of our Type
join implementation, which should be able to directly compute a join
of disparate types that share some common supertype, but sometimes
fails to in cases involving protocol compositions.

Fixes rdar://problem/45490737

(cherry picked from commit 85237aa)
@rudkx
Copy link
Contributor Author

rudkx commented Oct 24, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ce6879a

@rudkx
Copy link
Contributor Author

rudkx commented Oct 24, 2018

Linux failure is in configuring:

10:50:15 CMake Error at CMakeLists.txt:58 (find_package):
10:50:15   Could not find a package configuration file provided by "Swift" with any of
10:50:15   the following names:
10:50:15 
10:50:15     SwiftConfig.cmake
10:50:15     swift-config.cmake
10:50:15 
10:50:15   Add the installation prefix of "Swift" to CMAKE_PREFIX_PATH or set
10:50:15   "Swift_DIR" to a directory containing one of the above files.  If "Swift"
10:50:15   provides a separate development package or SDK, be sure it has been
10:50:15   installed.

@rudkx rudkx merged commit e2fbdb0 into swiftlang:swift-5.0-branch Oct 24, 2018
@rudkx rudkx deleted the rdar45490737-5.0 branch October 24, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants