[RemoteAST] Stop bypassing resilience when doing queries. #20026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test with following PR: @swift-ci Please test |
|
Build failed |
|
Build failed |
rjmccall
approved these changes
Oct 25, 2018
|
Thank you, John. |
slavapestov
approved these changes
Oct 26, 2018
| @@ -878,7 +877,7 @@ class RemoteASTContextImpl { | |||
| VarDecl *member = findField(typeDecl, memberName); | |||
|
|
|||
| // If we found a member, try to find its offset statically. | |||
| if (member) { | |||
| if (member && member->hasStorage() && !typeDecl->isResilient()) { | |||
There was a problem hiding this comment.
Why do we need this at all? Can we use mirrors to find the offset all the time? It should still work
Avoid going to IRGen with a resilient type to avoid crashing. This is tested in lldb. <rdar://problem/45049259>
|
Please test with following PR: @swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid going to IRGen with a resilient type to avoid crashing.
This is tested in lldb.
rdar://problem/45049259