[CSDiag] Fix crash related to failures in contextual type requirements #20028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nathawes
approved these changes
Oct 25, 2018
If failed constraint mentions member declaration which is not generic, it means that generic requirements came from context and should not be diagnosed by `diagnoseUnresolvedDotExprTypeRequirementFailure`. Resolved: rdar://problem/45511837
When constructing requirement failures make sure that requirement kind provided by the caller matches information about requirement stored in the locator.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If failed constraint mentions member declaration which is not
generic, it means that generic requirements came from context
and should not be diagnosed by
diagnoseUnresolvedDotExprTypeRequirementFailure.Resolved: rdar://problem/45511837