Generic super capture fix (2.2) #2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Oops, forgot to add CHECKs to the tests. Don't review just yet. |
slavapestov
force-pushed
the
generic-super-capture-fix-2.2
branch
from
9af6953 to
1eee149
Compare
|
@swift-ci Please test |
|
@jckarter Do you mind reviewing this? |
…generic signature Otherwise, we can miss that 'self' has a generic type when accessed via a 'super' call if the type of 'super' is concrete. This is a regression from a patch series to allow C function pointers to be formed from closures in generic contexts -- basically, the check was not conservative enough, and in this case, it would conclude the closure did not capture the generic signature when in reality it did: swiftlang@533f42d Fixes <rdar://problem/25439564>.
slavapestov
force-pushed
the
generic-super-capture-fix-2.2
branch
from
1eee149 to
908fae0
Compare
|
@swift-ci Please test |
|
@tkremenek Please take a look once @jckarter signs off on this |
|
Nice catch, LGTM. Is master also affected? |
|
Yeah, I'm going to push the fix to master shortly. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Oct 19, 2020
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes rdar://25439564, a Swift 2.2 regression where a crash could occur while compiling a closure satisfying a very specific set of conditions detailed in the bug report and tests.