-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[build-script] When building packages install llvm-cov, llvm-profdata… #20044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build-script] When building packages install llvm-cov, llvm-profdata… #20044
Conversation
… for use with swiftpm. rdar://44567818
@swift-ci build linux toolchain |
@swift-ci build toolchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To be clear, the linux change affects /all/ linux installations not just packages. |
@swift-ci smoke test |
Linux Toolchain (Ubuntu 16.04) Install command |
macOS Toolchain Install command |
I just verified by hand that both toolchains have llvm-cov and llvm-profdata installed. I am going to add an integration test in a separate PR. |
@swift-ci smoke test linux platform |
I tested the built linux toolchain, the codecov feature is indeed working. Thanks! |
@aciidb0mb3r can you put your test into an integration test? So we can make sure this always works? |
(just asking since you said you had an impl). |
I think the tsan test is XFAILed now. Lets try this once again. |
@swift-ci smoke test linux platform |
Yeah, I'll try to convert my test for the swift-integration-test repo. Unfortunately, that repo is always very hard to use locally if you don't build toolchains regularly. |
Opened PR for integration test: swiftlang/swift-integration-tests#35 |
… for use with swiftpm.
rdar://44567818
https://bugs.swift.org/browse/SR-9082
I think this will work. But lets see.