Skip to content

[build-script] When building packages install llvm-cov, llvm-profdata… #20044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Oct 25, 2018

… for use with swiftpm.

rdar://44567818
https://bugs.swift.org/browse/SR-9082


I think this will work. But lets see.

@gottesmm
Copy link
Contributor Author

@swift-ci build linux toolchain

@gottesmm
Copy link
Contributor Author

@swift-ci build toolchain

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gottesmm
Copy link
Contributor Author

To be clear, the linux change affects /all/ linux installations not just packages.

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - b24e333

Install command
tar zxf swift-PR-20044-77-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - b24e333

Install command
tar -zxf swift-PR-20044-93-osx.tar.gz --directory ~/

@gottesmm
Copy link
Contributor Author

I just verified by hand that both toolchains have llvm-cov and llvm-profdata installed. I am going to add an integration test in a separate PR.

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

@aciidgh
Copy link
Contributor

aciidgh commented Oct 25, 2018

I tested the built linux toolchain, the codecov feature is indeed working. Thanks!

@gottesmm
Copy link
Contributor Author

@aciidb0mb3r can you put your test into an integration test? So we can make sure this always works?

@gottesmm
Copy link
Contributor Author

(just asking since you said you had an impl).

@gottesmm
Copy link
Contributor Author

I think the tsan test is XFAILed now. Lets try this once again.

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

@gottesmm gottesmm merged commit 0ad5ff6 into swiftlang:master Oct 26, 2018
@gottesmm gottesmm deleted the pr-da4f63eeb78dff4e1978fe8f790a49e81cee8a9e branch October 26, 2018 01:15
@aciidgh
Copy link
Contributor

aciidgh commented Oct 26, 2018

Yeah, I'll try to convert my test for the swift-integration-test repo. Unfortunately, that repo is always very hard to use locally if you don't build toolchains regularly.

@aciidgh
Copy link
Contributor

aciidgh commented Oct 26, 2018

Opened PR for integration test: swiftlang/swift-integration-tests#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants