[typelowering] Look through 1 level of optionality when determining i… #20060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
slavapestov
approved these changes
Oct 26, 2018
…f a value has a NewType representation. This is necessary to ensure that we autorelease such values in objc thunks. Previously, we were returning the value as unowned, leaking it. I added a test to interpreter that will make sure in the future we do not leak like this again. rdar://45543138
gottesmm
force-pushed
the
pr-d72b9d7f8355cbe3c62d4424af52b4dae10ab1dd
branch
from
4e23b54 to
dd8edef
Compare
|
@swift-ci smoke test and merge |
|
lldb test failure on macOS. |
|
@swift-ci smoke test os x platform |
1 similar comment
|
@swift-ci smoke test os x platform |
|
@swift-ci smoke test os x platform |
|
Forgot to enable ownership verification on that test file (this was the failure that was blocking me from doing so). Going to do that in a follow up commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f a value has a NewType representation.
This is necessary to ensure that we autorelease such values in objc thunks.
Previously, we were returning the value as unowned, leaking it. I added a test
to interpreter that will make sure in the future we do not leak like this
again.
rdar://45543138