[CodeCompletion] Implement context type analysis at subscript position #20066
+93
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Why does the subscript case do a qualified lookup while the function case doesn't? |
|
As for free function case, overloaded candidates are usually preserved as |
|
Okay makes sense. I commented in that PR that we should share the implementation. Otherwise LGTM. |
rintaro
force-pushed
the
ide-completion-subscript
branch
from
42efc3f to
fc60c93
Compare
This improves completion for index part of subscript expression. rdar://problem/38920581
rintaro
force-pushed
the
ide-completion-subscript
branch
from
fc60c93 to
74356d6
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves completion for index part of subscript expression.
rdar://problem/38920581