Skip to content

[benchmark] Add benchmark for [AnyHashable: Any] with String keys #20067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions benchmark/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ set(SWIFT_BENCH_MODULES
single-source/DictionaryGroup
single-source/DictionaryKeysContains
single-source/DictionaryLiteral
single-source/DictionaryOfAnyHashableStrings
single-source/DictionaryRemove
single-source/DictionarySubscriptDefault
single-source/DictionarySwap
Expand Down
83 changes: 83 additions & 0 deletions benchmark/single-source/DictionaryOfAnyHashableStrings.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//

import TestsUtils

// This benchmark tests the performance of Dictionary<AnyHashable, Any> with
// small ASCII String keys. Untyped NSDictionary values get imported as this
// type, so it occurs relatively often in practice.

public var DictionaryOfAnyHashableStrings = [
BenchmarkInfo(
name: "DictionaryOfAnyHashableStrings_insert",
runFunction: run_DictionaryOfAnyHashableStrings_insert,
tags: [.abstraction, .runtime, .cpubench],
setUpFunction: {
keys = buildKeys(500)
}
),
BenchmarkInfo(
name: "DictionaryOfAnyHashableStrings_lookup",
runFunction: run_DictionaryOfAnyHashableStrings_lookup,
tags: [.abstraction, .runtime, .cpubench],
setUpFunction: {
keys = buildKeys(500)
workload = buildWorkload()
}
),
]

var keys: [String] = []
var workload: [AnyHashable: Any] = [:]

func buildKeys(_ size: Int) -> [String] {
var result: [String] = []
let keyPrefixes = ["font", "bgcolor", "fgcolor", "blink", "marquee"]
for key in keyPrefixes {
for i in 0 ..< size {
result.append(key + "\(i)")
}
}
return result
}

func buildWorkload() -> [AnyHashable: Any] {
precondition(keys.count > 0)
var result: [AnyHashable: Any] = [:]
var i = 0
for key in keys {
result[key] = i
i += 1
}
return result
}


@inline(never)
public func run_DictionaryOfAnyHashableStrings_insert(_ n: Int) {
precondition(keys.count > 0)
for _ in 0 ... n {
Copy link
Contributor

@palimondo palimondo Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah! Finally cracked the mystical setup overhead: one extra iteration. The loop should be either 1...n or 0..<n. I'll fix this in a next Janitor Duty legacyFactor pass.

blackHole(buildWorkload())
}
}

@inline(never)
public func run_DictionaryOfAnyHashableStrings_lookup(_ n: Int) {
precondition(workload.count > 0)
precondition(keys.count > 0)
for _ in 0 ... n {
for i in 0 ..< keys.count {
let key = keys[i]
CheckResults((workload[key] as! Int) == i)
}
}
}
2 changes: 2 additions & 0 deletions benchmark/utils/main.swift
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ import DictionaryCopy
import DictionaryGroup
import DictionaryKeysContains
import DictionaryLiteral
import DictionaryOfAnyHashableStrings
import DictionaryRemove
import DictionarySubscriptDefault
import DictionarySwap
Expand Down Expand Up @@ -226,6 +227,7 @@ registerBenchmark(DictionaryCopy)
registerBenchmark(DictionaryGroup)
registerBenchmark(DictionaryKeysContains)
registerBenchmark(DictionaryLiteral)
registerBenchmark(DictionaryOfAnyHashableStrings)
registerBenchmark(DictionaryRemove)
registerBenchmark(DictionarySubscriptDefault)
registerBenchmark(DictionarySwap)
Expand Down