Putting white spaces in between if/while clauses and braces. #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you change the commit message so that it specifically says that you are putting white spaces in between if/while clauses and braces with an example. |
wxxsw
changed the title
|
Thx @gottesmm |
|
Can you put a dummy example into the commit message so that people can understand without reading the actual diff what the patch does? Something like. [gardening] Put white spaces in between if/while clauses and braces where it is missing. For instance: 'if (foo){' => 'if (foo) {' |
…here it is missing.
For instance:
'if (foo){' => 'if (foo) {'
|
Thank you, it's better. |
|
@swift-ci Please test and merge |
|
The test failure looks like some other issue. These changes should be NFC. |
|
I had to revert this change since it introduced 80+ line violations. Please file a new diff with these changes, sans any of those 80+ line violations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Fix whitespaces.