[TypeJoin] Return Unimplemented (aka Type()) for things we cannot yet… #20073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compute. It's important not to return `Any` for joins that we cannot compute to distinguish them from ones that we currently can compute but result in `Any`. I don't have a test case for this that is independent of other changes that I have that are not yet ready to merge. With the testing infrastructure we have for join we don't currently have a way to test out cases that fail in this fashion.
|
@swift-ci Please smoke test |
xedin
reviewed
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… compute.
It's important not to return
Anyfor joins that we cannot compute todistinguish them from ones that we currently can compute but result in
Any.I don't have a test case for this that is independent of other changes
that I have that are not yet ready to merge. With the testing
infrastructure we have for join we don't currently have a way to test
out cases that fail in this fashion.