-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Experimental Dependencies] Add -enable-experimental-dependencies and push it through. #20078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidungar
merged 2 commits into
swiftlang:master
from
davidungar:manual-rebasing-exp-deps
Oct 30, 2018
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -206,6 +206,10 @@ class Compilation { | |
/// limit filelists will be used. | ||
size_t FilelistThreshold; | ||
|
||
/// Scaffolding to permit experimentation with finer-grained dependencies and | ||
/// faster rebuilds. | ||
const bool EnableExperimentalDependencies; | ||
|
||
template <typename T> | ||
static T *unwrap(const std::unique_ptr<T> &p) { | ||
return p.get(); | ||
|
@@ -234,7 +238,8 @@ class Compilation { | |
Optional<unsigned> BatchSizeLimit = None, | ||
bool SaveTemps = false, | ||
bool ShowDriverTimeCompilation = false, | ||
std::unique_ptr<UnifiedStatsReporter> Stats = nullptr); | ||
std::unique_ptr<UnifiedStatsReporter> Stats = nullptr, | ||
bool EnableExperimentalDependencies = false); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Getting convinced we need a CompilationOptions struct, but that doesn't have to be part of this patch. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, good points. |
||
~Compilation(); | ||
|
||
ToolChain const &getToolChain() const { | ||
|
@@ -289,6 +294,10 @@ class Compilation { | |
EnableIncrementalBuild = false; | ||
} | ||
|
||
bool getEnableExperimentalDependencies() const { | ||
return EnableExperimentalDependencies; | ||
} | ||
|
||
bool getBatchModeEnabled() const { | ||
return EnableBatchMode; | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option is to put this on a SourceFile's ReferencedNameTracker. I'm not sure if that's better since it means putting this flag in FrontendOptions just to pass it through, but it might be easier for whatever implementation you end up with to have the flag right there. Since that's inside the frontend, though, you can always change it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thought, will keep it in mind.