[closure-lifetime-fixup] When emitting a load_borrow, make sure to em… #20079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
Found a small typo... |
…it the end_borrow for it as well. In this commit I added a more convenient API for doing this sort of operation. Specifically: SILBuilder::emitScopedBorrowOperation. This performs either a load_borrow or begin_borrow, then calls a user provided closure, and finally inserts the end_borrow after the scope has closed. rdar://43398898
gottesmm
force-pushed
the
pr-b0fb5eb2f5151be44b6c9311c3d3fe015dc1fc5a
branch
from
6d0abbd to
e4607a7
Compare
|
Ok. It is ready now @aschwaighofer |
|
@swift-ci smoke test |
|
I think this is a straight forward enough change to do post commit review. When this finishes I want to immediately start the (long) testing of enabling ownership on all the stdlib overlays. |
|
LGTM |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…it the end_borrow for it as well.
In this commit I added a more convenient API for doing this sort of operation.
Specifically: SILBuilder::emitScopedBorrowOperation. This performs either a
load_borrow or begin_borrow, then calls a user provided closure, and finally
inserts the end_borrow after the scope has closed.
rdar://43398898