Skip to content

[SR-8961] Testcase for more-involved use of @_implements using @_nonoverride #20088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Oct 26, 2018

Provide a testcase for switching Comparable.< behaviour at an intermediate protocol using @_implements and @_nonoverride.

Resolves SR-8961.

rdar://45183426

@graydon graydon requested a review from stephentyrone October 26, 2018 23:14
@graydon
Copy link
Contributor Author

graydon commented Oct 26, 2018

@swift-ci please test

@graydon graydon requested a review from airspeedswift October 26, 2018 23:14
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8a072e6

@graydon
Copy link
Contributor Author

graydon commented Oct 29, 2018

@swift-ci please test OSX platform

2 similar comments
@graydon
Copy link
Contributor Author

graydon commented Nov 1, 2018

@swift-ci please test OSX platform

@graydon
Copy link
Contributor Author

graydon commented Nov 2, 2018

@swift-ci please test OSX platform

@stephentyrone
Copy link
Contributor

@swift-ci please test OSX

@jrose-apple
Copy link
Contributor

@swift-ci Please test macOS

@graydon
Copy link
Contributor Author

graydon commented Dec 18, 2018

@stephentyrone any sense of whether this fits the bill wrt. current needs?

@stephentyrone
Copy link
Contributor

@graydon yes, I think this is fine, but I believe that it's been obsoleted by Mark's #20903.

@graydon
Copy link
Contributor Author

graydon commented Dec 19, 2018

@stephentyrone ah great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants