[IRGen] Correctly emit metadata for ObjC class properties #2011
Conversation
|
@gparker42, mind reviewing? |
|
@swift-ci Please test |
| fields.push_back(buildPropertyList()); | ||
| fields[5] = buildPropertyList(ForClass); | ||
| // const property_list_t *classProperties; | ||
| fields[6] = buildPropertyList(ForMetaClass); |
There was a problem hiding this comment.
We added a uint32_t size = sizeof(category_t) field here (rdar://24804226).
|
Where are the objc image info flags set? There is a new one to indicate the presence of this data. Looks good other than the image info flags and the new category_t.size field. |
|
Clang is setting them for us, se we've just been broken for the last few weeks. Oops. Is there a good way to test that that doesn't depend on updates to the ObjC runtime? |
We rely on Clang to set these properly now. No functionality change.
jrose-apple
force-pushed
the
objc-class-property-metadata
branch
from
fb2b77e to
3f020ab
Compare
|
You can write a runtime test for class properties on class objects, at least, because the old runtime happens to handle them correctly. Check the result of |
|
Better than nothing. Thanks, Greg. |
...which is important because Clang CodeGen was already claiming we were! rdar://problem/25473573
jrose-apple
force-pushed
the
objc-class-property-metadata
branch
from
3f020ab to
4dd3c10
Compare
|
@swift-ci Please test |
...which is important because Clang CodeGen was already claiming we were!
Follow-up to 50e3b33. Resolves rdar://problem/25473573.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.