Skip to content

NFC: SILBasicBlock utilties for handling critical edges. #20111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2018
Merged

NFC: SILBasicBlock utilties for handling critical edges. #20111

merged 6 commits into from
Oct 29, 2018

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Oct 27, 2018

This is in preparation for a SILCloner cleanup PR (round 2/2).

Don't look at the combined diff.

I extracted the trivial cleanup into a serious of commits that are
individually very easy to review.

  • Some primary SILBasicBlock interfaces are moved into /SIL.
  • A SILCloner API is renamed.
  • A few trivial/obvious utility APIs are added.
  • Comments are added to various related code.

The primary interfaces for CFG manipulation belong in SIL. This is
just what's necessary to fix SILCloner.
A follow up commit adds an API for SILCloner clients to set mapped
values. Calling the map lookup "remap" would be unacceptably misleading.
@atrick
Copy link
Contributor Author

atrick commented Oct 27, 2018

@swift-ci test.

@atrick atrick merged commit 1446952 into swiftlang:master Oct 29, 2018
@atrick atrick deleted the critedge-util branch September 3, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant