[benchmark] Fix the swiftpm based benchmark build. #20117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a few things: 1. We were not updated for libProc's addition. I bumped the swiftpm version number to get the systemLibrary functionality (thanks Ankit). 2. I split up a bunch of lines to help the typechecker out a little bit.
|
This is NFC since this is only used for offline development in Xcode right now (hopefully we just switch to using this in general). |
|
@swift-ci smoke test |
aciidgh
approved these changes
Oct 28, 2018
aciidgh
reviewed
Oct 28, 2018
| publicHeadersPath: "."), | ||
| ] + singleSourceLibraries.map { x in | ||
| dependencies: [ | ||
| .target(name: "TestsUtils"), |
There was a problem hiding this comment.
You can use the shorthand and just use "TestsUtils" string directly. SwiftPM can figure out that you're referring to a target.
aciidgh
reviewed
Oct 28, 2018
| products.append(.library(name: "TestsUtils", type: .static, targets: ["TestsUtils"])) | ||
| products.append(.library(name: "DriverUtils", type: .static, targets: ["DriverUtils"])) | ||
| products.append(.library(name: "ObjectiveCTests", type: .static, targets: ["ObjectiveCTests"])) | ||
| products.append(.executable(name: "SwiftBench", targets: ["SwiftBench"])) |
There was a problem hiding this comment.
You only need this product, rest can be discarded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things:
We were not updated for libProc's addition. I bumped the swiftpm version
number to get the systemLibrary functionality (thanks Ankit).
I split up a bunch of lines to help the typechecker out a little bit.