Fix some crashers #20119
Merged
Fix some crashers #20119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps we should refactor everything so that extensions that are not at the top-level are still bound and type checked normally. However that requires a bit of work, so keep playing wack-a-mole for now to handle these invalid states when they come up. However while we're at it, make the code a little better by removing a bogus diagnostic path that was not used. Fixes <rdar://problem/45290211>, <https://bugs.swift.org/browse/SR-9009>.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
We diagnose and flag these in finalize(), but we can encounter one even earlier through resolveDependentMemberTypes(). Do the same thing there that we already do in EquivalenceClass::getTypeInContext(). Fixes <rdar://problem/45328122>, <https://bugs.swift.org/browse/SR-9022>.
|
The fix for https://bugs.swift.org/browse/SR-4812 needs more work so I'm taking it out for now. |
slavapestov
force-pushed
the
fix-some-crashers
branch
from
d3f95f8 to
add4185
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
This was referenced Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.