[Sema] Hide underscored names from typo-correction #20125
Conversation
|
We already have something similar in code completion -- should we share the logic between the two instead of adding new rules? |
|
I was looking into the code completion side of things as well, but wasn't sure where that logic was located. Are you thinking there's existing logic around leading-underscore names that could be reused here? |
|
Anything else needed here? |
|
@swift-ci Please test. |
|
Build failed |
|
That's definitely your failure to fix. |
|
Build failed |
adamshin
force-pushed
the
typo-correction-underscore
branch
from
0d4e1f9 to
45939f5
Compare
Identifiers with a leading underscore are now hidden from typo-correction unless the typed name also begins with an underscore.
adamshin
force-pushed
the
typo-correction-underscore
branch
from
45939f5 to
9d23ba2
Compare
|
@adamshin It looks like code completion calls Decl::isPrivateStdlibDecl(), which has a number of checks in addition to leading underscore. Can you try using that instead? |
|
Sorry, I was the one who wrote up the bug this way. We don't want to use |
|
@swift-ci Please test |
|
Build failed |
|
Looks like my changes broke a test (Parse/recovery.swift). I'm looking into that now. |
|
Build failed |
The unresolved identifier 'esp' used to have '_exp' as a typo-correction option. That's no longer the case, and the type checker now singles out 'test' as the unique correction.
|
@swift-ci Please test. |
|
Build failed |
|
Build failed |
|
Failure looks unrelated; let's try again. @swift-ci Please test Linux |
|
Thanks, Adam! |
Identifiers with a leading underscore are now hidden from typo-correction unless the typed name also begins with an underscore.
Resolves SR-9083.