[build-script] When building packages install libIndexStore from clang #20132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the LSP service.
|
@swift-ci build linux toolchain |
|
@swift-ci build toolchain |
compnerd
reviewed
Oct 29, 2018
utils/build-presets.ini
Outdated
| @@ -1062,7 +1062,7 @@ test-installable-package | |||
| reconfigure | |||
|
|
|||
| swift-install-components=compiler;clang-builtin-headers;stdlib;swift-syntax;sdk-overlay;license;sourcekit-xpc-service;swift-remote-mirror;swift-remote-mirror-headers | |||
| llvm-install-components=llvm-cov;llvm-profdata | |||
| llvm-install-components=llvm-cov;llvm-profdata;install-IndexStore | |||
There was a problem hiding this comment.
Shouldn't that be IndexStore and not install-IndexStore?
|
@akyrtzi Are you sure that install-IndexStore is right? It should be just IndexStore. |
|
@compnerd lol?! Who was first? Not sure. = p. |
|
@swift-ci build toolchain |
|
macOS Toolchain Install command |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
@akyrtzi Not sure, why GitHub did not update the status on the PR. |
|
Toolchains look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the LSP service.