[android] Do not link library absolute path. #20143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using the full path of the shared library to avoid including the absolute path of the library in the executable, which will not work once the library is moved to the host machine (like an Android device). To avoid doing a confussing `-lrary`, I changed the name of the library to `libAttrImplFP.so` instead.
|
Seems reasonable. @swift-ci Please test |
|
Build failed |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using the full path of the shared library to avoid including
the absolute path of the library in the executable, which will not
work once the library is moved to the host machine (like an
Android device).
To avoid doing a confussing
-lrary, I changed the name of thelibrary to
libAttrImplFP.soinstead.Depends on #19949 for correctly working on Android.