Skip to content

[build-script] Update build-script to support building and installing the SourceKit stress tester #20160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2018
Merged

[build-script] Update build-script to support building and installing the SourceKit stress tester #20160

merged 2 commits into from
Nov 10, 2018

Conversation

nathawes
Copy link
Contributor

@nathawes nathawes commented Oct 30, 2018 •
edited
Loading

Adds support to build-script to build, test and install the SourceKit stress tester. Most of the actual build/install is handled by a helper script in the swift-stress-tester repo.

This also updates the OS X package builder presets to build and install the stress tester executables (sk-stress-test and sk-swiftc-wrapper). I have a swift-integration-tests pull request open here to check it works correctly once it's in.

@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9c9643e55bbe873638b7d77fe456a3aaa0f37ff3

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9c9643e55bbe873638b7d77fe456a3aaa0f37ff3

@nathawes nathawes force-pushed the build-script-skstresstester branch 2 times, most recently from 9f2b5ea to 81df9e9 Compare November 3, 2018 01:38
@nathawes
Copy link
Contributor Author

nathawes commented Nov 3, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 3, 2018

Build failed
Swift Test OS X Platform
Git Sha - 9c9643e55bbe873638b7d77fe456a3aaa0f37ff3

@swift-ci
Copy link
Contributor

swift-ci commented Nov 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - 9c9643e55bbe873638b7d77fe456a3aaa0f37ff3

@nathawes nathawes force-pushed the build-script-skstresstester branch from 81df9e9 to c8e4a43 Compare November 3, 2018 02:44
@nathawes
Copy link
Contributor Author

nathawes commented Nov 3, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - 81df9e95cad04e781c618f0f6772bb9adfbe553e

@swift-ci
Copy link
Contributor

swift-ci commented Nov 3, 2018

Build failed
Swift Test OS X Platform
Git Sha - 81df9e95cad04e781c618f0f6772bb9adfbe553e

[build-script] Update build-script with a new --skstresstester flag t…
506307c 
…o support building and installing the SourceKit stress tester

This makes use of a helper script in the stress tester repo to do the actual
build and install: https://github.com/apple/swift-stress-tester/blob/master/SourceKitStressTester/Utilities/build-script-helper.py
@nathawes nathawes force-pushed the build-script-skstresstester branch from c8e4a43 to 506307c Compare November 7, 2018 17:15
@nathawes
Copy link
Contributor Author

nathawes commented Nov 8, 2018

@swift-ci Please build Toolchain macOS Platform

@nathawes nathawes changed the title [WIP][build-script] Update build-script to support building and installing the SourceKit stress tester [build-script] Update build-script to support building and installing the SourceKit stress tester Nov 9, 2018
@nathawes
Copy link
Contributor Author

nathawes commented Nov 9, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 9, 2018

Build failed
Swift Test OS X Platform
Git Sha - c8e4a43f6540009ff8caabac641bf0ed8dbd447b

nkcsgexi
nkcsgexi approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathawes
Copy link
Contributor Author

nathawes commented Nov 9, 2018

@swift-ci Please build Toolchain Linux Platform

shahmishal
shahmishal approved these changes Nov 10, 2018
View reviewed changes
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@nathawes nathawes merged commit 2e720c3 into swiftlang:master Nov 10, 2018
@nathawes nathawes deleted the build-script-skstresstester branch November 10, 2018 00:08
@shahmishal
Copy link
Member

@nathawes We are seeing failure due to missing script.

https://ci.swift.org/job/oss-swift-package-osx/2522/console

/Users/buildnode/jenkins/workspace/oss-swift-package-osx/swift/utils/build-script-impl: line 277: /Users/buildnode/jenkins/workspace/oss-swift-package-osx/swift-stress-tester/SourceKitStressTester/Utilities/build-script-helper.py: No such file or directory

@shahmishal shahmishal mentioned this pull request Nov 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathawes @swift-ci @shahmishal @nkcsgexi