Fix 2 Driver tests on Windows

[gmittert]

Most of the driver tests currently don't work on Windows, but these two
were relatively fixable.

• specifically target OSX in order to produce generate-dSYM
• alternatively match the full path of dsymutil, which on Windows is
  given as "C:\....\dsymutil.exe" verify-debug-info ...

Would it be useful to have a DEBUG_NONDARWIN etc that is the same as the DEBUG check but doesn't check for generate-dSYM and doesn't pass -target?

[jrose-apple]

Thanks for looking at this. I don't think this is necessarily the right change for actions.swift, which is already XFAILed on Linux and FreeBSD. I'd rather split it up into the target-agnostic tests and the target-specific tests—and then yes, a DEBUG_NONDARWIN (or DEBUG_NON_DSYM) check would make sense.

[gmittert]

So if I'm understanding correctly, leave actions.swift as is, but also xfail on windows, then add another test which doesn't check for dsym and doesn't xfail?

I mostly just fixed these so I'd have a passing test on Windows to add in a test for #20140, but if I were to go through and look at a few more, is one large PR easier, or is several each with a handful of tests easier?

[gmittert]

Updated to xfail on windows and split the actions test into dsym and non dsym.

[jrose-apple]

Sorry for the slow feedback!

[jrose-apple]

We're no longer using this FileCheck line, so you can just remove it. Actually, the invocation isn't really adding anything either at this point.

[jrose-apple]

Hm, I don't think this file should include any of the actions that don't use -g, since the tests are the same. And then I think it's okay for this file to use an explicit -target x86_64-apple-macosx10.9 like you had originally, so that we can remove the XFAILs. That's a compromise, but I think it's a reasonable one.

[gmittert]

Makes sense to me, I've removed them.

[jrose-apple]

@swift-ci Please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 06f6f4ab1152bfb3a94689eb6a946ee895336aca

[jrose-apple]

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/test/Driver/actions-dsym.swift:71:11: error: MULTI: expected string not found in input
// MULTI: 6: link, {1, 3, 5}, image
          ^
<stdin>:7:1: note: scanning from here
6: swift-autolink-extract, {1, 3, 5}, autolink
^
<stdin>:8:2: note: possible intended match here
7: link, {1, 3, 5, 6}, image
 ^

Looks like there's a -target missing somewhere.

[gmittert]

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/test/Driver/actions-dsym.swift:71:11: error: MULTI: expected string not found in input
// MULTI: 6: link, {1, 3, 5}, image
          ^
<stdin>:7:1: note: scanning from here
6: swift-autolink-extract, {1, 3, 5}, autolink
^
<stdin>:8:2: note: possible intended match here
7: link, {1, 3, 5, 6}, image
 ^

Looks like there's a -target missing somewhere.

Oof yeah, that should be removed anyways since it's not being passed -g

[gmittert]

Alright, updated and tested locally against all of Windows, MacOS, and Linux.

[jrose-apple]

@swift-ci Please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 06f6f4ab1152bfb3a94689eb6a946ee895336aca

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 06f6f4ab1152bfb3a94689eb6a946ee895336aca

[jrose-apple]

Thanks, sorry for all the delay!