IRGen: Use @_weakLinked to test backward deployment of resilient protocols #20173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
weak-linked
branch
from
239b890 to
f2ed056
Compare
…ocols Get the attribute working for more link entity kinds, which addresses all the FIXME:s in the original test case. Now the protocol resilience tests can be updated to use @_weakLinked for all newly-added protocol requirements and default implementations. This allows the tests to pass in the backward deployment test scenario as well. Eventually this will be based on availability instead of a special attribute. This completes <rdar://problem/29888071>.
slavapestov
force-pushed
the
weak-linked
branch
from
f2ed056 to
57979d1
Compare
slavapestov
changed the title
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
jrose-apple
reviewed
Nov 1, 2018
| return accessor->getStorage()->isWeakImported(fromModule); | ||
|
|
||
| if (auto *dtor = dyn_cast<DestructorDecl>(this)) | ||
| return cast<ClassDecl>(dtor->getDeclContext())->isWeakImported(fromModule); |
There was a problem hiding this comment.
I don't think we need this one. It should be covered by availability when we implement that, but otherwise you'd have to apply this rule to every member of every decl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the attribute working for more link entity kinds, which addresses
all the FIXME:s in the original test case.
Now the protocol resilience tests can be updated to use @_weakLinked
for all newly-added protocol requirements and default implementations.
This allows the tests to pass in the backward deployment test scenario
as well.
Eventually this will be based on availability instead of a special
attribute.
This completes rdar://problem/29888071.