Skip to content

[AutoDiff] Fix crasher when a closure with context gets differentiated #20186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2018
Merged

[AutoDiff] Fix crasher when a closure with context gets differentiated #20186

merged 1 commit into from
Nov 1, 2018

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Oct 31, 2018

This patch makes the following self-explanatory case possible.

  let val: Float = 10
  let clo: (Float) -> Float = { x in
    val * x
  }
  _ = #gradient(clo)

@rxwei rxwei requested a review from dan-zheng October 31, 2018 18:18
@rxwei rxwei force-pushed the gradient-partial-applied branch from fe5e5fc to 8e9a67e Compare October 31, 2018 18:20
@rxwei
Copy link
Contributor Author

rxwei commented Oct 31, 2018

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Oct 31, 2018

@swift-ci please test tensorflow macos

@rxwei
Copy link
Contributor Author

rxwei commented Oct 31, 2018

@swift-ci please test tensorflow macos

1 similar comment
@rxwei
Copy link
Contributor Author

rxwei commented Oct 31, 2018

@swift-ci please test tensorflow macos

@rxwei rxwei merged commit 7f79ae5 into swiftlang:tensorflow Nov 1, 2018
@rxwei rxwei deleted the gradient-partial-applied branch November 1, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-zheng dan-zheng dan-zheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rxwei @dan-zheng