[Mangling] Introduce mangling for protocol conformances. #20230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce complete mangling for references to protocol conformances: * Mangle requirements of conditional conformances when present. * Mangle conformance access paths for generic environment-dependent conformances. * Abstract protocol conformance references so we can introduce symbolic references for them.
…mangling Change the retroactive conformance mangling to use the new any-protocol-conformance mangling, which maintains more information about concrete conformances. Specifically, it maintains conformance information for conditional requirements. It also uses the protocol-conformance-ref production that will eventually allow symbolic references to protocol conformance descriptors. While here, extend the “is retroactive” check during mangling to look for retroactive conformances in the conditional requirements of a conformance. The immediate conformance might not be retroactive, but its specialization might depend on a retroactive conformance. Mangle these as “retroactive”, so we can correctly reconstruct the exact type.
DougGregor
force-pushed
the
mangled-protocol-conformances
branch
from
4fac77d to
5e232de
Compare
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
When determining whether a given normal protocol conformance is “retroactive”, consider an overlay module to be equivalent to its underlying Clang module. Therefore, don’t classify conformances within the overlay as “retroactive”, simplifying some common manglings (e.g., NSObject’s Hashable conformance is no longer considered retroactive) and better capturing the intent.
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
DougGregor
changed the title
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce complete mangling for references to protocol conformances:
conformances (currently unused)
symbolic references for them.