Remove imported reflection field descriptors #20235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
slavapestov
force-pushed
the
remove-imported-reflection-field-descriptors
branch
from
d6068f4 to
b85a115
Compare
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
…r own TypeRef Right now we expect that every class and protocol has a field descriptor that tells us if the entity is @objc or not. For imported types, the descriptor will not exist if we did not directly emit a field whose concrete type contains the imported type. For example, in lldb, we might have a generic type whose runtime substituted type includes an imported type. In this case, TypeLowering would fail to produce a layout because it did not find a field descriptor for the imported type. A better approach is to have the TypeDecoder call a different factory method for imported types, and handle them specially in TypeLowering, bypassing the field type metadata altogether.
…try point This will eventually replace swift::ide::getTypeFromMangledSymbolname().
slavapestov
force-pushed
the
remove-imported-reflection-field-descriptors
branch
from
b85a115 to
9074136
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@dcci Check out the last commit... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we expect that every class and protocol has a field
descriptor that tells us if the entity is @objc or not.
For imported types, the descriptor will not exist if we did not
directly emit a field whose concrete type contains the imported
type. For example, in lldb, we might have a generic type whose
runtime substituted type includes an imported type.
In this case, TypeLowering would fail to produce a layout because
it did not find a field descriptor for the imported type.
A better approach is to have the TypeDecoder call a different
factory method for imported types, and handle them specially in
TypeLowering, bypassing the field type metadata altogether.