Add a test for synthesized get-only properties in swiftinterfaces #20244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Thanks! I don't think these are tested in the other tests. |
harlanhaskins
approved these changes
Nov 2, 2018
|
Build failed |
|
Build failed |
|
Uh, hm, and we don't put them all on one line anymore. Oops. |
jrose-apple
force-pushed
the
getting-testy
branch
from
a7a5d83 to
c0e7c6c
Compare
|
@swift-ci Please smoke test |
jrose-apple
commented
Nov 2, 2018
| // CHECK-NEXT: public func hash(into hasher: inout Swift.Hasher) | ||
| // CHECK-NEXT: @inlinable public init?(rawValue: Swift.Int) | ||
| // CHECK-NEXT: public var rawValue: Swift.Int { | ||
| // CHECK-NEXT: @inlinable get{{$}} |
There was a problem hiding this comment.
This is a little unfortunate, I guess. (It's a synthesized body, so we don't know how to print it.)
|
@swift-ci please smoke test linux platform |
1 similar comment
|
@swift-ci please smoke test linux platform |
jrose-apple
force-pushed
the
getting-testy
branch
from
c0e7c6c to
5b86513
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably superfluous with all the other tests @harlanhaskins has been adding, but I wrote it and it was sitting around on my machine, so we might as well use it.