Revert "[Build System: CMake] make add_swift_library a wrapper to add_llvm_library" #20247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkcsgexi I think this was unreasonable to revert. Why should @compnerd have to revert something b/c of breakage in internal branches that he doesn't have access to? That is the responsibility of us and shouldn't revert in a public revert. That being said, you already did the revert so I will help with the merge-conflict later when I am available. |
|
@gottesmm Thank you for looking into the merge conflicts! |
|
@nkcsgexi no worries! Happy to help = ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch caused some merge conflicts. Defer to @gottesmm to merge and resolve the conflicts when he is available.